incus/config_template: Add file support config template create #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a rebase now :) |
awalvie
force-pushed
the
yaml-support-config-template-create
branch
from
1c0c55e
to
9019e12
Compare
|
Re-based it! Ready for review! |
|
Example should be changed as input should be a template file (pongo) and so .tpl extension, not YAML |
awalvie
force-pushed
the
yaml-support-config-template-create
branch
from
2084fe5
to
5cf111e
Compare
awalvie
changed the title
done! |
stgraber
approved these changes
Apr 23, 2024
|
Static analysis failed because the translation commit doesn't match the code. |
awalvie
force-pushed
the
yaml-support-config-template-create
branch
from
98e0334
to
07a280c
Compare
Sorry about that, have updated them! |
awalvie
force-pushed
the
yaml-support-config-template-create
branch
from
07a280c
to
52b47a1
Compare
|
Force pushed to re-trigger the CI. |
stgraber
force-pushed
the
yaml-support-config-template-create
branch
from
52b47a1
to
c7f38b3
Compare
stgraber
approved these changes
Apr 24, 2024
|
Github looks pretty messed up right now. I've confirmed that this is all clean and ready to merge but the Github UI won't even let me merge this yet :) I'll try again later. |
|
This needs a rebase now, hopefully Github can actually run the tests after that |
Part of lxc#741 Signed-off-by: Vishesh Agrawal <[email protected]>
Signed-off-by: Vishesh Agrawal <[email protected]>
awalvie
force-pushed
the
yaml-support-config-template-create
branch
from
c7f38b3
to
101ec89
Compare
stgraber
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #741